Separation of concerns

src/IO/Shell/Pdfinfo.php

@@ -13,13 +13,11 @@ class Pdfinfo
         $lines = $this->shellExec('pdfinfo', '-isodates', $filepath);
 
         $data = [];
-        foreach ($lines as $line) {
-            $parts = explode(':', $line, 2);
-            if (count($parts) === 2) {
-                $data[trim($parts[0])] = trim($parts[1]);
-            }
-        }
+        collect($lines)
+            ->map(fn(string $line) => explode(':', $line, 2))
+            ->filter(fn(array $parts) => count($parts) === 2)
+            ->each(fn(array $parts) => $data[trim($parts[0])] = trim($parts[1]));
 
-        return (new Metadata)->fillWith($data);
+        return Metadata::fill($data);
     }
 }