joopschilder/pdf-finder
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Important memory improvement

Browse Source
This commit is contained in:
Joop Schilder
2021-03-23 23:10:23 +01:00
parent 8f88b626f0
commit cc2696668c
4 changed files with 65 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
src/IO/Input/FinderArguments.php
View File

@@ -5,6 +5,7 @@ namespace IO\Input;
use Filter\DocumentFilter;
use Filter\FilterFactory;
use IO\Exception\DirectoryNotFoundException;
use IO\Exception\DirectoryNotReadableException;
use IO\Exception\NotADirectoryException;
class FinderArguments
@@ -14,15 +15,6 @@ class FinderArguments
private ?string $directory;
private array $filters;
public function __construct(?string $directory, array $filters)
{
$this->directory = $directory;
$this->filters = $filters;
$factory = new FilterFactory();
$this->filters = array_map([$factory, 'createFromString'], $this->filters);
}
public static function createFromGlobals(): self
{
$arguments = self::getArguments();
@@ -33,15 +25,17 @@ class FinderArguments
return new self($dir, $arguments);
}
public function __construct(?string $directory, array $filters)
{
$this->guardUnusableDirectory($directory);
$this->directory = realpath($directory);
$factory = new FilterFactory();
$this->filters = array_map([$factory, 'createFromString'], $filters);
}
public function getDirectory(): string
{
if (!file_exists($this->directory)) {
throw new DirectoryNotFoundException($this->directory);
}
if (!is_dir($this->directory)) {
throw new NotADirectoryException($this->directory);
}
return $this->directory;
}
@@ -52,4 +46,17 @@ class FinderArguments
{
return $this->filters;
}
private function guardUnusableDirectory(string $directory): void
{
if (!file_exists($directory)) {
throw new DirectoryNotFoundException($directory);
}
if (!is_dir($directory)) {
throw new NotADirectoryException($directory);
}
if (!is_readable($directory)) {
throw new DirectoryNotReadableException($directory);
}
}
}